yangwwei commented on a change in pull request #62:
URL:
https://github.com/apache/incubator-yunikorn-web/pull/62#discussion_r685699956
##########
File path: .github/workflows/main.yaml
##########
@@ -0,0 +1,37 @@
+name: Pre-commit Checks
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout Source Code
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 2
+
+ - name: Check License
+ run: make license-check
+
+ - name: Set Node.js Environment
+ uses: actions/setup-node@v2
+ with:
+ node-version: 12.14
+ - run: npm install -g @angular/cli > /dev/null
+ - run: npm install karma
+ - run: npm install -g protractor
+ - run: yarn install
Review comment:
I think this can be simplified to:
```
run: |
npm install -g @angular/cli > /dev/null
npm install karma
...
```
the above syntax is supported in github action for multi-line commands.
##########
File path: .github/workflows/main.yaml
##########
@@ -0,0 +1,37 @@
+name: Pre-commit Checks
+
+on:
+ pull_request:
+ branches:
+ - master
+
+jobs:
+ build:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout Source Code
+ uses: actions/checkout@v2
+ with:
+ fetch-depth: 2
+
+ - name: Check License
+ run: make license-check
+
+ - name: Set Node.js Environment
+ uses: actions/setup-node@v2
+ with:
+ node-version: 12.14
+ - run: npm install -g @angular/cli > /dev/null
+ - run: npm install karma
+ - run: npm install -g protractor
+ - run: yarn install
+
+ - name: Unit Test
+ run: ng test --watch=false
+
+ - name: Build Test
+ run: ng build
Review comment:
This should be "Build", not the "Build test"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
