0yukali0 commented on a change in pull request #281:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/281#discussion_r686502850
##########
File path: pkg/common/resource.go
##########
@@ -72,9 +72,32 @@ func GetPodResource(pod *v1.Pod) (resource *si.Resource) {
containerResource := getResource(resourceList)
podResource = Add(podResource, containerResource)
}
+
+ // vcore, mem compare between initcontainer and containers and replace
+ // For each resource, podResourceRequest = max(sum(Containers
requirement), InitContainers requirement)
+ if pod.Spec.InitContainers != nil {
+ isNeedMoreResourceAndSet(pod, podResource)
+ }
+
return podResource
}
+func isNeedMoreResourceAndSet(pod *v1.Pod, containersResources *si.Resource) {
+ for _, c := range pod.Spec.InitContainers {
+ resourceList := c.Resources.Requests
+ ICResource := getResource(resourceList)
+ for resourceName, ICRequest := range ICResource.Resources {
+ containersRequests, exist :=
containersResources.Resources[resourceName]
Review comment:
I will add test for this situation in next commit.
In my thought, it should be like following
loop1 men:2GB > 1GB replace.
loop2 GPU is not found in cont request, additional request add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
