chia7712 opened a new pull request #319:
URL: https://github.com/apache/incubator-yunikorn-core/pull/319
### What is this PR for?
All functions in `partition_manager` are using pass-by-value so setting the
`stop` flag to true can't terminate other threads.
```
func (manager partitionManager) Stop() {
manager.stop = true
}
```
Also, the thread used to cleanup expired app can't be stopped quickly after
removing partition because it needs to sleep for 24 hours.
```
func (manager partitionManager) cleanupExpiredApps() {
for {
if manager.stop {
break
}
manager.pc.cleanupExpiredApps()
time.Sleep(appRemovalInterval)
}
}
```
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-832
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
