manirajv06 commented on a change in pull request #322:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/322#discussion_r708831840
##########
File path: pkg/scheduler/partition.go
##########
@@ -483,11 +484,15 @@ func (pc *PartitionContext) GetQueueInfos()
dao.QueueDAOInfo {
return pc.root.GetQueueInfos()
}
+func (pc *PartitionContext) GetPartitionNameWithoutClusterID() string {
+ return common.GetPartitionNameWithoutClusterID(pc.Name)
Review comment:
Pls see above comment
##########
File path: pkg/scheduler/objects/allocation.go
##########
@@ -118,6 +118,10 @@ func NewAllocationFromSI(alloc *si.Allocation) *Allocation
{
return NewAllocation(alloc.UUID, alloc.NodeID, ask)
}
+func (a *Allocation) GetPartitionNameWithoutClusterID() string {
+ return common.GetPartitionNameWithoutClusterID(a.PartitionName)
Review comment:
Do we need this method? "common" scope is already available in
handlers.go. Can we use it directly in handlers.go?
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -128,6 +128,10 @@ func (sa *Application) SetState(state string) {
sa.stateMachine.SetState(state)
}
+func (sa *Application) GetPartitionNameWithoutClusterID() string {
+ return common.GetPartitionNameWithoutClusterID(sa.Partition)
Review comment:
Pls see above comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
