pbacsko commented on pull request #308: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/308#issuecomment-939875976
> This looks much better and simpler. I have one small ask: now that you removed the admission review response log message, we don't have any information in the logs related the validity of the configmap. Please add a small log message for the case when the configmap is the YK configmap. You can add it in `validateConfigMap` function As we discussed on Slack, all errors are logged. If there's no message, it means that the validation is passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
