craigcondit commented on a change in pull request #310:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/310#discussion_r731053971
##########
File path: pkg/cache/context.go
##########
@@ -75,9 +77,15 @@ func NewContext(apis client.APIProvider) *Context {
// init the controllers and plugins (need the cache)
ctx.nodes = newSchedulerNodes(apis.GetAPIs().SchedulerAPI,
ctx.schedulerCache)
- /* FUTURE YUNIKORN-872 replace this with predicateManager initilization
in YUNIKORN-874
- ctx.predictor = plugin.NewPredictor(schedulercache.GetPluginArgs(),
apis.IsTestingMode())
- */
+ // create the predicate manager
+ if !apis.IsTestingMode() {
+ sharedLister := support.NewSharedLister(ctx.schedulerCache)
+ k8sClient :=
client.NewKubeClient(conf.GetSchedulerConf().KubeConfig)
+ clientSet := k8sClient.GetClientSet()
+ informerFactory :=
informers.NewSharedInformerFactory(clientSet, 0)
Review comment:
will update in new patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
