craigcondit commented on a change in pull request #313:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/313#discussion_r732905347
##########
File path: pkg/cache/external/scheduler_cache_test.go
##########
@@ -91,7 +91,8 @@ func TestAssignedPod(t *testing.T) {
assert.Check(t, cachedNode.Node() != nil, "host0001
exists in cache but the ref to v1.Node doesn't exist")
assert.Equal(t, cachedNode.Node().Name, node.Name)
assert.Equal(t, cachedNode.Node().UID, node.UID)
- assert.Equal(t, len(cachedNode.Pods()), 1)
+ assert.Assert(t, cachedNode != nil && cachedNode.Pods
!= nil, "pods was nil")
+ assert.Equal(t, len(cachedNode.Pods), 1)
Review comment:
Yes, but the linter doesn't believe this:
```
pkg/cache/external/scheduler_cache_test.go:94:35: SA5011: possible nil
pointer dereference (staticcheck)
assert.Equal(t, len(cachedNode.Pods), 1)
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
