manirajv06 commented on pull request #332: URL: https://github.com/apache/incubator-yunikorn-core/pull/332#issuecomment-951009241
Since this is an WIP pr, please refer the below notes(Below info applies for other related PR's as well) for this commit: Made changes only for "SECTION 2: Breaking the Shim build dependency on Core by moving the plugins to Scheduler Interface" * Moved all plugins from core to appropriate place in SI under single common existing interface itself rather than having different interface as I though this model is clean and good. Let me know if you think otherwise. * As opposed to introducing new events (as documented) to go through via rmproxy, made the changes to call those plugin directly from the core, node etc as I thought add more new events is unnecessary. To do: 1. Need to discuss and see how we can break the dependency completely as there are some places in shim where code refers core directly. 2. Need to see if we can merge ReloadConfiguration and UpdateConfiguration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
