yangwwei commented on a change in pull request #334:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/334#discussion_r737114848



##########
File path: pkg/metrics/scheduler.go
##########
@@ -141,6 +142,15 @@ func InitSchedulerMetrics() *SchedulerMetrics {
                        Buckets:   prometheus.ExponentialBuckets(0.0001, 10, 
6), //start from 0.1ms
                },
        )
+       s.tryNodeLatency = prometheus.NewHistogram(
+               prometheus.HistogramOpts{
+                       Namespace: Namespace,
+                       Subsystem: SchedulerSubsystem,
+                       Name:      "try_node_latency_seconds",
+                       Help:      "Latency of trynode, in seconds.",

Review comment:
       Can we explain this metrics a bit more like:
   `Latency of node condition checks for container allocations, such as 
placement constraints, in seconds`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to