manirajv06 commented on a change in pull request #56:
URL:
https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/56#discussion_r738406991
##########
File path: scheduler-interface-spec.md
##########
@@ -563,54 +598,50 @@ State transition of node:
See protocol below:
-Registration of a new node with the scheduler. If the node exists then the
request will be rejected.
-```protobuf
-message NewNodeInfo {
- // ID of node, must be unique
- string nodeID = 1;
- // node attributes
- map<string, string> attributes = 2;
- // Schedulable Resource
- Resource schedulableResource = 3;
- // Occupied Resource
- Resource occupiedResource = 4;
- // Allocated resources, this will be added when node registered to RM
(recovery)
- repeated Allocation existingAllocations = 5;
-}
-```
-
-Update of a registered node with the scheduler. If the node does not exist the
update will fail.
+During new node registration with the scheduler, request will be rejected if
the node exist already.
+While updating registered node with the scheduler, request will fail if the
node doesn't exist.
```protobuf
-message UpdateNodeInfo {
+message NodeInfo {
// Action from RM
enum ActionFromRM {
+
+ // Create Node
+ CREATE = 0;
Review comment:
Yep, let's use this opportunity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
