kingamarton commented on a change in pull request #326:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/326#discussion_r748044355
##########
File path: pkg/appmgmt/general/general.go
##########
@@ -320,13 +320,14 @@ func (os *Manager) deletePod(obj interface{}) {
}
func (os *Manager) ListApplications()
(map[string]interfaces.ApplicationMetadata, error) {
+ log.Logger().Info("Listing recoverable apps")
// list all pods on this cluster
slt := labels.NewSelector()
appPods, err := os.apiProvider.GetAPIs().PodInformer.Lister().List(slt)
if err != nil {
return nil, err
}
-
+ log.Logger().Info("Got the list of pods from the api server",
zap.Int("nr of pods", len(appPods)))
// get existing apps
existingApps := make(map[string]interfaces.ApplicationMetadata)
for _, pod := range appPods {
Review comment:
Added 3 extra fields: total pod nr, nr of pods without app metadata, nr
of pods linked to recoverable apps
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
