craigcondit commented on a change in pull request #328:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/328#discussion_r748429170
##########
File path: pkg/plugin/predicates/predicate_manager.go
##########
@@ -23,9 +23,9 @@ import (
"fmt"
"go.uber.org/zap"
+ admissionV1 "k8s.io/api/admission/v1"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/runtime"
- "k8s.io/kube-scheduler/config/v1beta1"
Review comment:
I think this should be "k8s.io/kube-scheduler/config"...
##########
File path: scripts/generate-groups.sh
##########
@@ -45,7 +45,7 @@ Usage: $(basename "$0") <generators> <output-package>
<apis-package> <groups-ver
Examples:
- $(basename "$0") all github.com/example/project/pkg/client
github.com/example/project/pkg/apis "foo:v1 bar:v1alpha1,v1beta1"
Review comment:
These changes shouldn't be in this PR, as they aren't relevant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
