wilfred-s commented on a change in pull request #356:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/356#discussion_r781734588
##########
File path: pkg/scheduler/objects/node.go
##########
@@ -316,15 +316,17 @@ func (sn *Node) AddAllocation(alloc *Allocation) bool {
return false
}
-// Replace the paceholder allocation on the node. No usage changes as the
placeholder must
-// be the same size as the real allocation.
-func (sn *Node) ReplaceAllocation(uuid string, replace *Allocation) {
+// ReplaceAllocation replaces the placeholder with the real allocation on the
node.
+// The delta passed in is the difference in resource usage between placeholder
and real allocation.
+// It should always be a negative value (really a decreased usage).
Review comment:
added log entry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
