manirajv06 commented on a change in pull request #357:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/357#discussion_r795354186
##########
File path: pkg/webservice/handlers.go
##########
@@ -670,8 +670,11 @@ func getPartitionInfoDAO(lists
map[string]*scheduler.PartitionContext) []*dao.Pa
partitionInfo.LastStateTransitionTime =
partitionContext.GetStateTime().String()
capacityInfo := dao.PartitionCapacity{}
- capacityInfo.Capacity =
partitionContext.GetTotalPartitionResource().DAOString()
- capacityInfo.UsedCapacity =
partitionContext.GetAllocatedResource().DAOString()
+ capacity := partitionContext.GetTotalPartitionResource()
Review comment:
Can you avoid using "capacity" variable and set the value directly to
capacityInfo.Capacity? or do you see any other benefit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
