craigcondit commented on pull request #365: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/365#issuecomment-1036416347
Updated PR with fix for crash discovered by @brickyard, as well as additional unit tests to bring add/update/remove node methods in scheduler_cache to 100% branch coverage, verifying that patch fixes crash. At this point we have far better tested code for this than upstream. @yangwwei, can you sign off on this? I know you have some concerns about the differences from upstream, but at this point I think they are theoretical. Let's address in a follow-up JIRA if we discover a regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
