anuraagnalluri commented on a change in pull request #369:
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/369#discussion_r806327376
##########
File path: test/e2e/basic_scheduling/basic_scheduling_test.go
##########
@@ -70,6 +70,16 @@ var _ = ginkgo.Describe("", func() {
Ω(err3).NotTo(HaveOccurred())
Ω(d).NotTo(BeNil())
+ ginkgo.By("Restart scheduler pod")
+ _, err4 := kClient.ScaleDeployment(configmanager.YKScheduler,
0, configmanager.YuniKornTestConfig.YkNamespace)
+ gomega.Ω(err4).NotTo(gomega.HaveOccurred())
+ err5 :=
kClient.WaitForPodBySelectorTerminated(configmanager.YuniKornTestConfig.YkNamespace,
fmt.Sprintf("component=%s", configmanager.YKScheduler), 60)
Review comment:
I'm really not sure why this timeout had to be 60. Waiting for pods to
be fully terminated (this does not correspond to "terminating" in k8s state
diagram, but rather failing an existence check for any pods with the `selector`
labels in the given `namespace`) takes around 10-12 seconds. But even setting
30 here leads to a `timeout exceeded` error. Wasn't sure how to debug this or
estimate the value more properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
