wilfred-s commented on a change in pull request #367:
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/367#discussion_r809701705



##########
File path: pkg/scheduler/partition.go
##########
@@ -1314,6 +1317,8 @@ func (pc *PartitionContext) removeAllocation(release 
*si.AllocationRelease) ([]*
                                zap.String("appID", appID),
                                zap.String("allocationId", uuid),
                                zap.Error(err))
+               } else {
+                       
metrics.GetQueueMetrics(queue.QueuePath).IncReleasedContainer()

Review comment:
       I think this should be a GetQueuePath() call and not a direct access to 
the QueuePath




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to