craigcondit commented on pull request #368: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/368#issuecomment-1050058525
> @craigcondit can you please check if the e2e test failed as expected and that this will work in combination with your changes. If we need changes for YUNIKORN-1084 I think we need to commit this first and add changes to that PR. Yes, this test will fail currently because the changes from YUNIKORN-1084 have not yet been merged (the existing behavior is not correct, but this test assumes it is). I don't think we need changes to this, but YUNIKORN-1084 needs to go in first to get the admission controller to exhibit the correct behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
