craigcondit edited a comment on pull request #373: URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/373#issuecomment-1050060452
> `parseRegexes` really needs a test > > * garbage input causes failure > * more than 1 reg exp in string (split check) > * escape character, i.e. what happens with a , do we see expected result > Just some sanity checks so we know it works Added more tests in latest commit. Have verified 100% coverage of all lines / branches in parseRegexes() and initAdmissionController(). Commas are not valid characters in namespaces anyway, so we don't support escaping them (i.e. `\,` here). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
