wilfred-s commented on pull request #372: URL: https://github.com/apache/incubator-yunikorn-core/pull/372#issuecomment-1050371393
This is looking good now, that side is good to go. > Are we going to add some tests? If you can then yes that would be the preferred option. We do have the limitation that we can only register one RM at the moment we need to keep that in mind. We can "fake" multiple RMs for the build info... Simple test that we should consider: - context test: register a RM with a couple of values, check that the cluster context has the correct details - web service test: extend the existing TestGetClusterUtilJSON and check the RM details are there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
