chia7712 commented on a change in pull request #328:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/328#discussion_r815296623
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -77,6 +78,7 @@ type Application struct {
execTimeout time.Duration // execTimeout for the
application run
placeholderTimer *time.Timer // placeholder replace timer
gangSchedulingStyle string // gang scheduling style
can be hard (after timeout we fail the application), or soft (after timeeout we
schedule it as a normal application)
+ finishedTime *time.Time // the time of finishing
this application. the default value is nil
Review comment:
@wilfred-s I use `nil` to replace zero time, since `nil` implies there
is no `finishedTime` currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
