wilfred-s commented on a change in pull request #385:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/385#discussion_r829693806
##########
File path: pkg/webservice/handlers.go
##########
@@ -289,7 +292,18 @@ func getApplicationJSON(app *objects.Application)
*dao.ApplicationDAOInfo {
ApplicationID: alloc.ApplicationID,
Partition: alloc.PartitionName,
}
- allocationInfos = append(allocationInfos, allocInfo)
+ allocationInfo = append(allocationInfo, allocInfo)
+ }
+
+ for _, taskGroup := range placeholders {
+ phInfo := dao.PlaceholderDAOInfo{
+ TaskGroupName: taskGroup.TaskGroupName,
Review comment:
Need a test to cover this
##########
File path: pkg/scheduler/objects/application.go
##########
@@ -892,6 +903,10 @@ func (sa *Application) tryPlaceholderAllocate(nodeIterator
func() NodeIterator,
alloc.Result = Replaced
// mark placeholder as released
ph.released = true
+ // store number of palceHolders that have been
replaced so far
+ if sa.placeholderData != nil {
+
sa.placeholderData[ph.taskGroupName].Replaced++
+ }
Review comment:
I think a better point is the real replacement: `ReplaceAllocation()`
After the check for a duplicate message. That means the placeholder is
really replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
