pbacsko commented on a change in pull request #384:
URL:
https://github.com/apache/incubator-yunikorn-core/pull/384#discussion_r833598542
##########
File path: pkg/scheduler/objects/application_state.go
##########
@@ -171,6 +175,9 @@ func NewAppState() *fsm.FSM {
},
fmt.Sprintf("leave_%s", Running.String()): func(event
*fsm.Event) {
app := event.Args[0].(*Application)
//nolint:errcheck
+ if app.queue != nil {
+ app.queue.runningApps--
Review comment:
Have you tried it?
I think these changes first need to be tested on sample setup with
KIND/Minikube to see what happens.
Could you do that? I would like to know what happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
