pbacsko commented on a change in pull request #395:
URL: https://github.com/apache/yunikorn-core/pull/395#discussion_r835664659



##########
File path: pkg/scheduler/context.go
##########
@@ -54,6 +55,8 @@ type ClusterContext struct {
        startTime time.Time
 
        sync.RWMutex
+
+       healthCheckCache *dao.SchedulerHealthDAOInfo

Review comment:
       The name "lastHealthCheckResult" sounds more appropriate to me. "cache" 
makes me think that it's something more complicated, like a data structure or 
something.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to