craigcondit commented on a change in pull request #400:
URL: https://github.com/apache/yunikorn-k8shim/pull/400#discussion_r837589819
##########
File path: deployments/image/configmap/start-yunikorn.sh
##########
@@ -33,4 +33,4 @@ exec /opt/yunikorn/bin/k8s_yunikorn_scheduler \
-enableConfigHotRefresh="${ENABLE_CONFIG_HOT_REFRESH}" \
-disableGangScheduling="${DISABLE_GANG_SCHEDULING}" \
-userLabelKey="${USER_LABEL_KEY}" \
- -placeHolderImage="${PLACEHOLDER_IMAGE}"
Review comment:
We can revert this file as only whitespace changes present now (and
removes the newline).
##########
File path: deployments/image/plugin/Dockerfile
##########
@@ -28,26 +28,12 @@ ADD start-yunikorn-plugin.sh
/opt/yunikorn/bin/start-yunikorn-plugin.sh
ADD scheduler-config.yaml /opt/yunikorn/work/scheduler-config.yaml
RUN chmod 755 /opt/yunikorn/bin/*
-ENV CLUSTER_ID "mycluster"
Review comment:
All of these removals should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
