ronazhan commented on pull request #369:
URL: https://github.com/apache/yunikorn-k8shim/pull/369#issuecomment-1083519351


   > Specifically, the suite passes and allocations list is non-empty.
   
   `appsInfo allocations are: []`
   
   @anuraagnalluri Just to clarify, the remaining failure is due to the test 
expecting a nil object representing an application's allocations, but instead 
it receives an allocation list of length 0? 
   
   This seems like a minor acceptable behavior change, but @yangwwei can you 
help confirm this to be expected now? Ideally, this should be consistent 
between plugin and regular Yunikorn versions. 
   
   For now, I would recommend adding an if statement check to keep the test 
backwards compatible with previous versions. If the allocations object is not 
nil, validate that the allocations length is 0. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to