craigcondit commented on a change in pull request #149:
URL: https://github.com/apache/yunikorn-site/pull/149#discussion_r839972483
##########
File path: docs/api/scheduler.md
##########
@@ -375,6 +377,9 @@ In the example below there are three allocations belonging
to two applications.
"kubernetes.io/meta/namespace": "default",
"kubernetes.io/meta/podName": "task0"
},
+ "requestTime":1648754034098912461,
Review comment:
Let's add a space after these to be consistent with the rest of the
file. There's several instances of this.
##########
File path: docs/api/scheduler.md
##########
@@ -31,6 +31,8 @@ Many of these APIs return collections of resources.
Internally, all resources ar
are returned in units of bytes while resources of type `vcore` are returned in
units of millicores
(thousands of a core). All other resource types have no specific unit assigned.
+Under the `allocations` field in the response content for the apps/nodes
related calls in the following spec, `placeholderUsed` refers to whether or not
the allocation is a replacement for a placeholder. If true, `requestTime` is
the creation time of its placeholder allocation, otherwise it's that of the
allocation's ask. `allocationTime` is the creation time of the allocation, and
`allocationDelay` is simply the difference between `allocationTime` and
`requestTime`.
Review comment:
Let's make `apps/nodes` -> `app / node-related`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
