yuchaoran2011 commented on code in PR #404:
URL: https://github.com/apache/yunikorn-k8shim/pull/404#discussion_r844703926
##########
pkg/shim/scheduler.go:
##########
@@ -213,7 +213,7 @@ func (ss *KubernetesShim) recoverSchedulerState(e
*fsm.Event) {
recoverableAppManagers =
append(recoverableAppManagers, m)
}
}
- if err := ss.context.WaitForRecovery(recoverableAppManagers,
30*time.Second); err != nil {
+ if err := ss.context.WaitForRecovery(recoverableAppManagers,
5*time.Minute); err != nil {
Review Comment:
Around mid 2021, I used to observe that recovery could fail relatively
frequently. When it did, it never recovered and we could benefit from knowing
the failure sooner rather than later. That's why @chenya-zhang introduced this
change to fail really quickly (in 30 secs). A ton of things have changed over
the last year, 5 minutes should be fine. But I'll keep an eye on what if any
failed recovery scenarios could occur
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
