craigcondit commented on code in PR #277:
URL: https://github.com/apache/yunikorn-k8shim/pull/277#discussion_r848955731
##########
pkg/cache/application.go:
##########
@@ -58,6 +58,7 @@ type Application struct {
placeholderAsk *si.Resource // total placeholder request
for the app (all task groups)
placeholderTimeoutInSec int64
schedulingStyle string
+ requestOriginatingPod *v1.Pod // Original Pod which creates the
requests
Review Comment:
I think we can make this less confusing for users if we ensure that all the
placeholder timeout events are the same (i.e. don't include the placeholder
ID). This way, the kubernetes UI tools will coalesce those (100) events down to
a single entry with a counter. This is very useful and not at all overwhelming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
