steinsgateted commented on code in PR #422:
URL: https://github.com/apache/yunikorn-k8shim/pull/422#discussion_r882895998
##########
pkg/cache/application.go:
##########
@@ -696,14 +603,7 @@ func (app *Application) handleFailApplicationEvent(event
*fsm.Event) {
}
}
-func (app *Application) handleReleaseAppAllocationEvent(event *fsm.Event) {
- eventArgs := make([]string, 2)
- if err := events.GetEventArgsAsStrings(eventArgs, event.Args); err !=
nil {
- log.Logger().Error("fail to parse event arg", zap.Error(err))
- return
- }
- allocUUID := eventArgs[0]
- terminationTypeStr := eventArgs[1]
+func (app *Application) handleReleaseAppAllocationEvent(allocUUID string,
terminationTypeStr string) {
Review Comment:
Done. Thanks.
##########
pkg/cache/application.go:
##########
@@ -721,14 +621,7 @@ func (app *Application)
handleReleaseAppAllocationEvent(event *fsm.Event) {
}
}
-func (app *Application) handleReleaseAppAllocationAskEvent(event *fsm.Event) {
- eventArgs := make([]string, 2)
- if err := events.GetEventArgsAsStrings(eventArgs, event.Args); err !=
nil {
- log.Logger().Error("fail to parse event arg", zap.Error(err))
- return
- }
- taskID := eventArgs[0]
- terminationTypeStr := eventArgs[1]
+func (app *Application) handleReleaseAppAllocationAskEvent(taskID string,
terminationTypeStr string) {
Review Comment:
Done. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
