craigcondit commented on PR #430: URL: https://github.com/apache/yunikorn-k8shim/pull/430#issuecomment-1147494104
> LGTM. > > By any chance, can we get the data race issue in plugin mode? I don't think so as I don't see using snapshot in scheduler_plugin.go. Just trying to confirm.. The race can occur in plugin mode, however, the scheduler_plugin.go file only covers the plugin implementation itself. It delegates to the same context and scheduler_cache objects that are used in standard mode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
