wilfred-s commented on code in PR #421:
URL: https://github.com/apache/yunikorn-core/pull/421#discussion_r918871099
##########
pkg/webservice/handlers.go:
##########
@@ -240,6 +240,7 @@ func getApplicationJSON(app *objects.Application)
*dao.ApplicationDAOInfo {
Count: taskGroup.Count,
MinResource: taskGroup.MinResource.DAOMap(),
Replaced: taskGroup.Replaced,
+ Timeout: taskGroup.Timedout,
Review Comment:
Missing "d" in the name: Time**d**Out Also capitalise the `O`
##########
pkg/webservice/dao/application_info.go:
##########
@@ -48,4 +48,5 @@ type PlaceholderDAOInfo struct {
Count int64 `json:"count"`
MinResource map[string]int64 `json:"minResource"`
Replaced int64 `json:"replaced"`
+ Timeout int64 `json:"timeout"`
Review Comment:
Missing "d" in the name: Time**d**Out Also capitalise the `O`
json field should be timedout also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
