craigcondit commented on code in PR #444:
URL: https://github.com/apache/yunikorn-k8shim/pull/444#discussion_r937987962
##########
pkg/plugin/predicates/predicate_manager.go:
##########
@@ -75,12 +74,7 @@ func (p *predicateManagerImpl) predicatesReserve(pod
*v1.Pod, node *framework.No
func (p *predicateManagerImpl) predicatesAllocate(pod *v1.Pod, node
*framework.NodeInfo) (plugin string, error error) {
ctx := context.Background()
state := framework.NewCycleState()
- plugin, err := p.podFitsNode(ctx, state, *p.allocationPreFilters,
*p.allocationFilters, pod, node)
- if err != nil {
- events.GetRecorder().Eventf(pod.DeepCopy(), nil,
v1.EventTypeWarning,
- "FailedScheduling", "FailedScheduling", "predicate is
not satisfied, error: %s", err.Error())
- }
- return plugin, err
+ return p.podFitsNode(ctx, state, *p.allocationPreFilters,
*p.allocationFilters, pod, node)
Review Comment:
We don't bother to log this for reservations, I don't really see a need to
log here either. This can quickly get overwhelming as this can happen multiple
times per second and is of little value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
