lixmgl commented on code in PR #429:
URL: https://github.com/apache/yunikorn-core/pull/429#discussion_r1028317321
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1164,13 +1175,16 @@ func (sq *Queue) TryReservedAllocate(iterator func()
NodeIterator) *Allocation {
zap.String("appID", appID))
return nil
}
- alloc := app.tryReservedAllocate(headRoom,
iterator)
- if alloc != nil {
- log.Logger().Debug("reservation found
for allocation found on queue",
- zap.String("queueName",
sq.QueuePath),
- zap.String("appID", appID),
- zap.String("allocation",
alloc.String()))
- return alloc
+ if app.IsStarting() || app.IsRunning() ||
app.IsAccepted() {
+ alloc :=
app.tryReservedAllocate(headRoom, iterator)
+ if alloc != nil {
+ log.Logger().Debug("Rainie test
accepted apps: reservation found for allocation found on queue",
Review Comment:
good catch, removed :)
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1292,3 +1306,71 @@ func (sq *Queue) String() string {
return fmt.Sprintf("{QueuePath: %s, State: %s, StateTime: %x,
MaxResource: %s}",
sq.QueuePath, sq.stateMachine.Current(), sq.stateTime,
sq.maxResource)
}
+
+func (sq *Queue) incRunningApps() {
+ if sq == nil {
+ return
+ }
+ if sq.parent != nil {
+ sq.parent.incRunningApps()
+ }
+ sq.Lock()
+ defer sq.Unlock()
+ sq.runningApps++
+}
+
+func (sq *Queue) decRunningApps() {
+ if sq == nil {
+ return
+ }
+ if sq.parent != nil {
+ sq.parent.decRunningApps()
+ }
+ sq.Lock()
+ defer sq.Unlock()
+ sq.runningApps--
+}
+
+func (sq *Queue) incAllocatingAcceptedAppsIfCanRun(sa *Application) bool {
+ if sq == nil {
+ return false
+ }
+ success := true
+ if sq.parent != nil {
+ success = sq.parent.incAllocatingAcceptedAppsIfCanRun(sa)
+ }
+ return sq.InternalIncAllocatingAcceptedAppsIfCanRun(success, sa)
+}
+
+func (sq *Queue) InternalIncAllocatingAcceptedAppsIfCanRun(success bool, sa
*Application) bool {
Review Comment:
Sure, combined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
