wilfred-s commented on code in PR #214: URL: https://github.com/apache/yunikorn-site/pull/214#discussion_r1028674904
########## docs/developer_guide/env_setup.md: ########## @@ -109,6 +109,29 @@ Without setting the enviromnent minikube might not find the docker images when d 1. run the image build from the yunikorn-k8shim repository root: `make image` 1. deploy the scheduler as per the normal instructions. +## Local Kubernetes Cluster with Kind + +Kind (Kubernetes in Docker) is a lightweight tool for running lightweight Kubernetes environments. It is very easy to test different Kubernetes versions with kind. You can just select the kind image you want. + +### Installation + +If you have go installed, you can run `go install sigs.k8s.io/kind@latest`. Review Comment: We need to mention that the kind version is linked to supported Kubernetes versions. i.e. for K8s 1.25 you must have at least kind v0.15 ########## docs/developer_guide/dependencies.md: ########## @@ -47,7 +47,7 @@ require ( ) ``` Release branches **must** not use pseudo versions. -During the creation of a release, [tags](/community/release_procedure#tag-and-update-release-for-version) will be created. +During the creation of a release, [tags](../../src/pages/community/release_procedure.mdrelease_procedure#tag-and-update-release-for-version) will be created. Review Comment: the website build converts the links, this looks broken. `local_build.sh run` will build and run the site on your local machine to check ########## docs/developer_guide/env_setup.md: ########## @@ -109,6 +109,29 @@ Without setting the enviromnent minikube might not find the docker images when d 1. run the image build from the yunikorn-k8shim repository root: `make image` 1. deploy the scheduler as per the normal instructions. +## Local Kubernetes Cluster with Kind + +Kind (Kubernetes in Docker) is a lightweight tool for running lightweight Kubernetes environments. It is very easy to test different Kubernetes versions with kind. You can just select the kind image you want. + +### Installation + +If you have go installed, you can run `go install sigs.k8s.io/kind@latest`. + +Other ways can be found on the Kind [website](https://kind.sigs.k8s.io/docs/user/quick-start/#installation) + +### Using Kind + +To test a new version of Kubernetes, you can pull a corresponding image from kind's repo. + +Creating a 1.23.13 Kubernetes Cluster: `kind create cluster --name test --image kindest/node:v1.23.13` Review Comment: Should move to v1.24.7 in the example ########## docs/developer_guide/env_setup.md: ########## @@ -109,6 +109,29 @@ Without setting the enviromnent minikube might not find the docker images when d 1. run the image build from the yunikorn-k8shim repository root: `make image` 1. deploy the scheduler as per the normal instructions. +## Local Kubernetes Cluster with Kind + +Kind (Kubernetes in Docker) is a lightweight tool for running lightweight Kubernetes environments. It is very easy to test different Kubernetes versions with kind. You can just select the kind image you want. + +### Installation + +If you have go installed, you can run `go install sigs.k8s.io/kind@latest`. + +Other ways can be found on the Kind [website](https://kind.sigs.k8s.io/docs/user/quick-start/#installation) + +### Using Kind + +To test a new version of Kubernetes, you can pull a corresponding image from kind's repo. + +Creating a 1.23.13 Kubernetes Cluster: `kind create cluster --name test --image kindest/node:v1.23.13` + +Deleting a kind cluster: `kind delete cluster --name test` + +### Loading your images + +In order to use a local image, you have to load your images into kind's registry. If you run `make image`, you could use the following command to load your kind image. This assumes AMD64 architecture. Review Comment: Extend this to mention all images that could be used (admission, scheduler, plugin and web), not just the scheduler ########## docs/developer_guide/build.md: ########## @@ -84,7 +84,7 @@ The docker image built from previous step has embedded some important build info these info with docker `inspect` command. ``` -docker inspect apache/yunikorn:scheduler-latest +docker inspect apache/yunikorn:scheduler-amd64-latest Review Comment: Please mention that this is an architecture specific value. The default depends on the HW used. ARM based machines: arm64v8, Intel/AMD: amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
