wilfred-s commented on code in PR #452:
URL: https://github.com/apache/yunikorn-core/pull/452#discussion_r1030989894
##########
pkg/scheduler/objects/application.go:
##########
@@ -886,6 +886,40 @@ func (sa *Application) tryAllocate(headRoom
*resources.Resource, nodeIterator fu
zap.String("required node",
requiredNode))
return nil
}
+
+ // Are there any non daemon set reservations on
specific required node?
+ // Cancel those reservations to run daemon set pods
+ reservations := node.getReservations()
+ if len(reservations) > 0 {
+ unreserve := true
+ for _, res := range node.getReservations() {
+ // skip the node
Review Comment:
nit: can be fixed on commit, explain why we skip the node. Even I had to
think twice why we would skip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
