wilfred-s opened a new pull request, #466: URL: https://github.com/apache/yunikorn-core/pull/466
### What is this PR for? The cleanup code needs a "cleanup" Refactoring of cleanupExpiredApps to rely on just application ID lists. Make GetAppsByState, GetRejectedAppsByState & GetCompletedAppsByState internal to the partition and change the return value Remove GetAppsInTerminatedState and GetTotalCompletedApplicationCount as they are unused or only for test and not needed. Cleanup tests to use assert.Equal instead of asser.Assert ### What type of PR is it? * [X] - Refactoring ### What is the Jira issue? * https://issues.apache.org/jira/browse/YUNIKORN-1445 ### How should this be tested? Covered by existing unit test. Code coverage should increase slightly as checks are run via methods instead of direct value access -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
