craigcondit commented on code in PR #82:
URL: 
https://github.com/apache/yunikorn-scheduler-interface/pull/82#discussion_r1043542000


##########
scheduler-interface-spec.md:
##########
@@ -448,6 +448,21 @@ message AllocationAsk {
   bool placeholder = 10;
   // Is this ask the originator of the application?
   bool Originator = 11;
+  // The preemption policy for this ask
+  PreemptionPolicy preemptionPolicy = 12;
+}
+```
+
+Preemption policy:
+
+```protobuf
+message PreemptionPolicy {
+  // Allow preemption while running

Review Comment:
   We should remove the comments referring to Kubernetes. These should simply 
describe their purpose, nothing more (i.e. "whether task can preempt 
lower-priority tasks" and "whether task can be preempted by higher-priority 
tasks") or something.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to