pbacsko commented on code in PR #501:
URL: https://github.com/apache/yunikorn-k8shim/pull/501#discussion_r1047501359
##########
pkg/admission/admission_controller.go:
##########
@@ -197,6 +199,7 @@ func (c *AdmissionController) processPod(req
*admissionv1.AdmissionRequest, name
if c.shouldLabelNamespace(namespace) {
patch = updateLabels(namespace, &pod, patch)
+ patch = c.updatePreemptionInfo(&pod, patch)
Review Comment:
I think some refactor or clean-up is becoming unavoidable in this file. It's
getting larger and these functions are inconsistent (there are more). Not in
scope, just saying, maybe it's worth a follow-up JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
