akhilpb001 commented on code in PR #101:
URL: https://github.com/apache/yunikorn-web/pull/101#discussion_r1086269558
##########
src/app/components/dashboard/dashboard.component.ts:
##########
@@ -100,27 +108,32 @@ export class DashboardComponent implements OnInit {
});
this.eventBus.getEvent(EventMap.LayoutChangedEvent).subscribe(() => {
- this.updateAppStatusData(this.clusterInfo);
- this.updateContainerStatusData(this.clusterInfo);
+ this.updateAppStatusData(this.partitionList[0].applications);
+ this.updateContainerStatusData(this.partitionList[0]);
this.appHistoryData = this.getAreaChartData(this.initialAppHistory);
this.containerHistoryData =
this.getAreaChartData(this.initialContainerHistory);
});
}
- updateAppStatusData(info: ClusterInfo) {
+ updateAppStatusData(applications: Applications) {
this.appStatusData = [
- new DonutDataItem('Failed', +info.failedApplications, '#cc6164'),
- new DonutDataItem('Pending', +info.pendingApplications, '#facc54'),
- new DonutDataItem('Running', +info.runningApplications, '#26bbf0'),
- new DonutDataItem('Completed', +info.completedApplications, '#60cea5'),
+ new DonutDataItem('New', applications.New, '#facc54'),
Review Comment:
These many states seems overflowing in the UI. Could you please add the
non-zero states conditionally so that only the non-zero states are rendered and
will not overflow most of the cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
