zhuqi-lucas opened a new pull request, #513:
URL: https://github.com/apache/yunikorn-core/pull/513
### What is this PR for?
Wildcard interpretation
Wildcard can only be used as the only entry in the limit object according to
the documentation. There can be multiple limit objects in the overall limits
for a queue. As part of this design the interpretation of the wildcard needs to
be defined. Wildcards interpretation is related to the ordering of the limit
objects in the overall limits object. The usage and interpretation will be
different for users and groups.
In general terms: allowing a wildcard in the user or group list only as part
of the last entry of the limits list. After the wildcard has been added for
either the user or group list we do not allow a user or group list with a non
wildcard entry. This is especially important for the group resolution. It does
allow specifying a user and group wildcard with different limits set. In all
cases, there will only be a match using the wildcard if none of the earlier
limit entries match.
As part of the already existing queue configuration processing the syntax
for the configuration is checked. This check is triggered also for a reload of
the file, via the config map. Rudimentary limit object checking is implemented
as part of the config check.
The above described changes around the wildcards and what is allowed is not
part of the configuration validation and must be added.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg.
`[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
