craigcondit commented on PR #555: URL: https://github.com/apache/yunikorn-k8shim/pull/555#issuecomment-1478625437
> Or, are you suggesting we should remove the timeout here? Yes, that's exactly what I'm suggesting. Describe the failure scenario where a timeout would be hit legitimately (i.e. not simply because we didn't set it high enough). I submit there isn't one, as the underlying K8s client should be doing reliable transport recovery. So, the best thing we can do is get out of the way. I *am* in favor of polling and logging that we're still waiting (with a timer for how long it has been) as this is useful diagnostic information. But we should get rid of the arbitrary timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
