wilfred-s commented on PR #517: URL: https://github.com/apache/yunikorn-core/pull/517#issuecomment-1478769672
I am not sure about this. It reduces duplication of code at the cost of: - ease of debugging, the inlined function is more difficult to track. - extra code lines, even after I remove the license header the new solution uses 10 more lines of code, - overhead, the two extra function calls add extra work at runtime. It might also need an unwind as soon as we start looking at enforcing the quotas set and not just do the tracking in [YUNIKORN-1573](https://issues.apache.org/jira/browse/YUNIKORN-1573) That requires more work to be done under the lock which would be different for the group and user tracker -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
