pbacsko commented on PR #557: URL: https://github.com/apache/yunikorn-k8shim/pull/557#issuecomment-1480745268
> Not entirely thrilled with the "int as tri-state bool" pattern... It just feels ugly. An enum with constants might be cleaner, and easier to follow in the logic. True/False/Maybe. We get type safety that way too. +1 on this, naming the values increases readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
