zhuqi-lucas commented on code in PR #522:
URL: https://github.com/apache/yunikorn-core/pull/522#discussion_r1148357038
##########
pkg/scheduler/ugm/user_tracker.go:
##########
@@ -97,3 +97,7 @@ func (ut *UserTracker) GetUserResourceUsageDAOInfo()
*dao.UserResourceUsageDAOIn
userResourceUsage.Queues = ut.queueTracker.getResourceUsageDAOInfo("")
return userResourceUsage
}
+
+func (ut *UserTracker) CleanDeletedQueueTracker(queuePath string) {
Review Comment:
Good suggestion, addressed in latest PR.
##########
pkg/scheduler/partition_manager.go:
##########
@@ -120,6 +121,12 @@ func (manager *partitionManager) cleanQueues(queue
*objects.Queue) {
log.Logger().Debug("unexpected failure removing
the queue",
zap.String("partitionName",
manager.pc.Name),
zap.String("queue", queue.QueuePath))
+ } else {
+ // we should clean the queue tracker for ths
deleted queue
+ log.Logger().Debug("removing queueTracker",
+ zap.String("queueName",
queue.QueuePath),
+ zap.String("partitionName",
manager.pc.Name))
+
ugm.GetUserManager().CleanDeletedQueueTrackers(queue.QueuePath)
Review Comment:
Good suggestion, addressed in latest PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
