wilfred-s commented on code in PR #558:
URL: https://github.com/apache/yunikorn-k8shim/pull/558#discussion_r1150714070
##########
go.sum:
##########
@@ -248,6 +246,8 @@ github.com/elazarl/goproxy
v0.0.0-20180725130230-947c36da3153/go.mod h1:/Zj4wYkg
github.com/elazarl/goproxy v0.0.0-20200421181703-e76ad31c14f6
h1:GhNw/V+7mWhxPyD/n7STfwp/MJJ+Z/sa6wmzYXr96Ls=
github.com/elazarl/goproxy v0.0.0-20200421181703-e76ad31c14f6/go.mod
h1:Ro8st/ElPeALwNFlcTpWmkr6IoMFfkjXAvTHpevnDsM=
github.com/elazarl/goproxy/ext v0.0.0-20190711103511-473e67f1d7d2/go.mod
h1:gNh8nYJoAm43RfaxurUnxr+N1PwuFV3ZMl/efxlIlY8=
+github.com/elihschiff/yunikorn-core v0.0.0-20230323143210-256d1c68ca76
h1:M/eYosxv43Aeh3GkTI10H7cXgs7szAh7BXKZRwoZLvo=
Review Comment:
see above.
##########
pkg/common/resource.go:
##########
@@ -189,6 +184,7 @@ func GetResource(resMap map[string]string) *si.Resource {
func GetTGResource(resMap map[string]resource.Quantity, members int64)
*si.Resource {
result := NewResourceBuilder()
+ result.AddResource("pods", members)
Review Comment:
Need to add to the `cache.TestNewPlaceholder()` test code before we create a
new placeholder that the resource is correct on the app:
```
// check app update from taskgroup set
assert.Equal(t, app.placeholderAsk.Resources[siCommon.CPU].Value,
int64(10*500))
assert.Equal(t, app.placeholderAsk.Resources[siCommon.Memory].Value,
int64(10*1024*1000*1000))
assert.Equal(t, app.placeholderAsk.Resources["pods"].Value, int64(10))
```
and check as part of the holder pod:
```
assert.Equal(t, common.GetPodResource(holder.pod).Resources["pods"].Value,
int64(1))
```
##########
go.mod:
##########
@@ -45,6 +45,7 @@ require (
)
replace (
+ github.com/apache/yunikorn-core v0.0.0-20230222073958-e80580b1a67f =>
github.com/elihschiff/yunikorn-core v0.0.0-20230323143210-256d1c68ca76
Review Comment:
please remove the go.mod and go.sum updates, the change can be committed
without the update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
