manirajv06 commented on PR #529: URL: https://github.com/apache/yunikorn-core/pull/529#issuecomment-1534815226
@zhuqi-lucas Created a new pr https://github.com/apache/yunikorn-core/pull/538 for the following reasons: 1. Simplified whole logic for ease of reasoning. 2. New method code flow is in line with existing methods like checkQueueMaxApps & checkQueueMaxResources. Hence it is more easier for us to understand and make changes going forward. 3. In case of empty or nil or lower limit settings at any child Queue level with respect to the Parent Queue limit settings, minimum of both settings should be used to do checks down the level. Please refer the usage of resources.ComponentWiseMinPermissive() method. Please take a look and share your reviews. @wilfred-s can you take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
