zhuqi-lucas commented on code in PR #584:
URL: https://github.com/apache/yunikorn-k8shim/pull/584#discussion_r1193400578
##########
pkg/appmgmt/general/general_test.go:
##########
@@ -208,10 +210,12 @@ func TestOriginatorPod(t *testing.T) {
}
am.AddPod(&pod1)
assert.Equal(t, len(app.GetNewTasks()), 2)
- task, err = app.GetTask("UID-POD-00002")
+ task, err = app.GetTask("UID-POD-00001")
Review Comment:
Hi @wilfred-s , if we always return the pod, the test here the originator
will be the pod1 who first add into cluster.
I think that's right, because we only assign the ownerreference to
placeholders, the placeholders only have the originator pod as the
owerreference!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
