pbacsko commented on code in PR #559:
URL: https://github.com/apache/yunikorn-core/pull/559#discussion_r1217714281
##########
pkg/events/event_system.go:
##########
@@ -29,39 +29,45 @@ import (
// need to change for testing
var defaultEventChannelSize = 100000
-var cache *EventCache
+var ev EventSystem
-type EventCache struct {
- Store EventStore // storing eventChannel
+type EventSystem interface {
Review Comment:
Changed this to an interface so that we can mock easier when needed
##########
pkg/events/event_system.go:
##########
@@ -29,39 +29,45 @@ import (
// need to change for testing
var defaultEventChannelSize = 100000
-var cache *EventCache
+var ev EventSystem
-type EventCache struct {
- Store EventStore // storing eventChannel
+type EventSystem interface {
Review Comment:
Changed this to an interface so that we can mock it easier when needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
