zhuqi-lucas commented on PR #561:
URL: https://github.com/apache/yunikorn-core/pull/561#issuecomment-1588500613
Good explain @FrankYang0529, and for test case, for test case we have no RM
callback, so it will call the predicateChecks[0], if we need to handle this
special for test case, or real case will meet this also for no RM callback?
cc @craigcondit
```
// check for RM callback
plugin := plugins.GetResourceManagerCallbackPlugin()
if plugin == nil {
// if a plugin isn't registered, assume checks will succeed and
synthesize a result
check := predicateChecks[0]
log.Logger().Debug("No RM callback plugin registered, using
first selected node for preemption",
zap.String("NodeID", check.NodeID),
zap.String("AllocationKey", check.AllocationKey))
result := &predicateCheckResult{
allocationKey: check.AllocationKey,
nodeID: check.NodeID,
success: true,
index: int(check.StartIndex),
}
result.populateVictims(victimsByNode)
return result
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
